Split-TU: extract RewireHoistedPreludePregCombineAndVarExportCallArgSendSlots (#36387) - #37055
Merged
PurHur merged 2 commits intoSep 6, 2026
Conversation
…endSlots (#36387) Move hoisted-prelude / preg_replace / array_combine / var_export nested call-arg SEND rewires (~781 lines) out of RewireInlineCallArgSendSlots so gen-0 split-TU can hollow a smaller Concern TU. Hub wire + spine require + sidecar stamp; ratchet Compiler hub budget. Mirrors php-src Zend/zend_execute.c ZEND_SEND_* adjacent call-arg wiring — move-only. Co-authored-by: Cursor <cursoragent@cursor.com>
…ern extract (#36387) Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
deleted the
agent/issue-36387-rewire-hoisted-prelude-preg-combine-varexport
branch
September 6, 2026 19:37
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rewireRegisterShutdownFunctionClosureEnumCallArgSendSlots→rewireVarExportNestedInlineCallArgSendSlots(~637 lines) fromRewireInlineCallArgSendSlotsintoRewireHoistedPreludePregCombineAndVarExportCallArgSendSlots.RewireArithmeticBranch…, which already owns arithmetic→sibling multi-arg + hoisted-prelude helpers). Hub wire + spine require + sidecar stamp; Compiler hub budget 1145→1148; spine 8344→8345.Zend/zend_execute.cZEND_SEND_*adjacent call-arg wiring — no new C ABI.Test plan
./script/aot-smoke.sh→ 9/9 + size gate OK (post-rebase)make north-star5-verify-fast→ OK (spine 8345/8345)php script/check-selfhost-spine-count-sync.php/snapshot.php --check/check-size-budgets/ sidecar sync → OK./script/phpunit.sh --filter 'BootstrapSelfhostBundleTest|SizeBudget'→ OK (4 tests); BundleTest assert 8345script/differential-sweep.sh --aot --repeat 3(move-only; opcode-corpus-md5 OK via check-generated-docs)Part of #36387.
Made with Cursor