Repository navigation
Launch is one press: no Review step, and a busy agent plugin no longer fails the launch - #276
Merged
Merged
Conversation
…r fails the launch The launch reviews its session inside the press and starts it when the review shows what the panel showed; a review that differs is held and the next press launches it. Nothing reviews without a press, so the main control never flips between Launch, Review and Reviewing on its own. Doors that validate an Agent's profile are asked again when Manifold refuses them while OMP's isolate is busy, and that refusal is said in plain words.
Owner
Author
|
Independent review at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The workbench's main control had a separate Review step between a saved team and its launch, and it ran on its own: any observed input that moved (an account observation refresh, the model list's check status, OMP defaults, an account plugin restart) revoked the saved team's review and re-ran it after a short settle, so the control flipped between Launch, Review and Reviewing… without a press. An edited team whose projection was not grounded offered Save & review, which stopped at the review.
Agent Run launches could also fail on a busy agent plugin: Manifold validates the Agent's profile with a context-free request that needs OMP's isolate to serve nothing else, and otherwise answers
unavailablewithexclusive request requires a drained guest, which the panel showed raw. On the preview both observed launches failed that way while ordinary panel reads were in flight.Change
nextLaunchStephasverify | save | launch; thereviewstep, thereviewintent, the auto-review (autoReviewDue,AUTO_REVIEW_SETTLE_MS),groundedand the Review, Save & review and Reviewing… labels are gone. Nothing reviews without a press.launch()reviews the session immediately before starting it and goes on when the review shows what the panel showed (reviewMatches). One that differs is held (HeldReview) and the press stops with "What will run differs" and the differences; the next press launches the held review while it stands. A hold stands on the press's own inputs (team, options, machine, saved profile, authority) and explicit pins (OMP defaults and skill catalog revisions, successful reads, its launch still being the step), and is dropped for good the first time one fails. A press stands on the same inputs, so an observation that moves meanwhile no longer stops it; the launch already re-reads the accounts and OMP defaults itself (reviewedComposition).createCodeWorkflowClientasks againcore.access.registerAgentV2,updateAgentV2andlaunchRun(the doors that validate the Agent's profile) when refused withexclusive request requires a drained guestorprofile validation requires exclusive guest access, after 150/300/600/1200 ms; a refusal that outlasts that reads "OMP was busy for a moment. Try again." and the Run is cancelled as before. No other door is retried, so a model check's cancellation and currency checks are untouched. Launch-related refusals no longer tell the person to "Review again".effectiveSkillMode/effectiveSkillCountremoved; the scope only resume still uses is named for it.docs/configuration.md(the launch, one press, the workflow contract),README.md,docs/status.md(the busy-validation evidence boundary).Evidence
launchRunand a busyregisterAgentV2are asked again and the launch goes on; a busy refusal that outlasts the retries is said in words and its Run cancelled; a non-validating door is never retried;reviewDifferencesand the "What will run differs" line. Both busy tests fail without the retry.verify-browser.ts, real Chromium, real pinned OMP bundles): the launch readslaunch readythrough ~6.6 s of re-reads with noreviewSession; one press dispatchesreviewSessionthen the launch doors (Agent Run doors orprepareSession), readinglaunching…throughout; Save & launch readssave & launch→saving…→launching…in one press; a canvas-less Save never readslaunching…; a press whose own review shows an account pool the panel did not show stops on "What will run differs", the line survives ~3.4 s of re-reads, and the next press launches it with no newreviewSession.omp-updated, authoring): the label stayedlaunch | readyfor 15 s idle with noreviewSession; one press wentlaunching…→ review → session preparation (the lab refuses the session) →launch | readywith the refusal on the line; an edited team readsave & launch, thensaving…("Saving the workspace profile") →launching…("Opening a terminal on …") in the same press; no sideways scroll at 390 px.scripts/gate.shatb71c261605: exit 0 (tsc, 452 unit tests, pack, consumer, hardened and packaged verification, browserPASS (485s), native). An earlier gate run at the same head failed once in the kept-checks scenario at "the machine list opens" (the machine dropdown on a freshly opened workspace, a step this change does not touch); the browser verifier alone then passed, and so did this full gate.Closes #275