Clarify release approval and operator override decisions - #2516
Merged
5 commits merged intoSep 27, 2026
Merged
5 commits merged into
5 commits merged into
Conversation
This was referenced Sep 26, 2026
This was referenced Sep 26, 2026
cbusillo
added a commit
that referenced
this pull request
Sep 27, 2026
…48394978cf872d7: merge PR #2516
Owner
|
Launchplane completed the merge-train step for this pull request.
Launchplane landed this pull request through protected batch PR #2526. Launchplane manages this comment and will update it as the train moves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release review currently presents production and testing commits as an arrow and leaves the consequence of an operator override easy to misread. The page now leads with the proposed changes and testing link, explains the viewer's role and each decision, and places explicitly labeled current/proposed versions in collapsed Technical details.
Owner decisions and operator overrides have separate controls and explanations. The latest written feedback stays above the checklist, and an unpublished release record is visibly pending. Server authorization, decision precedence, promotion, and backup gates are unchanged.
Validation: frontend validation passed (74 tests, API drift, TypeScript, production build/fixture exclusion); the shared desktop/narrow browser suite passed 124 cases, followed by 8 release-review cases after review fixes. Interactive Chrome review covered Owner and operator initial/recorded/changes-requested states, Technical details, and no horizontal overflow at measured 1440px and 390px CSS widths. Only local fixtures were submitted. Browser screenshots are retained in the browser-smoke test artifacts. Ruff and formatting passed. JetBrains explicit inspection of all six PR files returned RED with 31 findings, all on unchanged lines. The previous clean-worktree changed-files report did not prove full PR coverage. No new-line finding, suppression, or profile change.
Independent review: Anthropic
claude-opus-5-5found three low-severity wording gaps. All were addressed: describe latest feedback without promising history, show pending release-record publication, and explain that Request changes replaces an earlier operator override. Authorization and fixture isolation were reviewed without findings. Background review is not yet observable at PR creation.Owner test notes: Review a local or non-production release checklist at desktop and phone widths. Confirm the testing link and changes are prominent; expand Technical details to identify current and proposed production versions. Confirm Owner acceptance, requested changes, and operator override have distinct consequences. Do not submit a real CM decision while its delivery hold remains.
Refs #2500. Kept separate from the #2513 diagnostic fix for the approved two-entry #2494 qualification. The approved pair is now delivered.
Delivery: final source checks and all 65 combined candidate checks passed. LP landed #2516 and #2517 through protected batch #2526 in one controller call at
42b8e589b967623df736b38657313c58174e3402, tracelaunchplane_req_5904e4ed57d6494d8888b5abb4d9d25a. Post-merge CI, Security, CodeQL, and Deploy Launchplane succeeded. The live image digest matches that exact landing. #2494 records the full qualification, separate admissions/outcomes, and managed feedback. Source refs were restored unchanged after GitHub's existing automatic post-merge deletion; no extra merge occurred. Local task evidence and IDE state are preserved, and the task worktree/local branch are removed.Read-only Chrome verification of the deployed release-review page confirmed the operator explanation, separate override justification, and Current/Proposed production labels inside initially collapsed Technical details. No real decision was submitted. Owner/phone and feedback-state evidence remains in the retained fixture browser artifacts.