Skip to content

fix(licensing): support COCOTEC_AUTH_TOKEN_FILE - #260

Open
GPLeemrijse wants to merge 1 commit into
fix/local-acquire-licence-pathfrom
fix/auth-token-file
Open

GPLeemrijse wants to merge 1 commit into
fix/local-acquire-licence-pathfrom
fix/auth-token-file

Conversation

@GPLeemrijse

@GPLeemrijse GPLeemrijse commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

local_acquire only read COCOTEC_AUTH_TOKEN, so a token given as a file acquired no licence. COCOTEC_AUTH_TOKEN_FILE now wins; only its path is passed to cocotec-licensing-server at fetch time (see #264), so the token's contents never enter the build. A relative path is reported as an acquisition error when popili runs.

Tests: a unit test for auth_token_source; CI gains a local_acquire job with the token in a file.

@GPLeemrijse
GPLeemrijse force-pushed the fix/auth-token-file branch 2 times, most recently from 0eeab98 to d003163 Compare November 5, 2026 21:42
@GPLeemrijse
GPLeemrijse changed the base branch from main to fix/local-user-licence-path November 5, 2026 21:43
@GPLeemrijse
GPLeemrijse added this pull request to stack #259 November 5, 2026 21:44
@GPLeemrijse
GPLeemrijse force-pushed the fix/auth-token-file branch 2 times, most recently from 1028645 to 1d435b9 Compare November 6, 2026 00:28
@GPLeemrijse
GPLeemrijse requested a review from tomgr November 6, 2026 16:51
@GPLeemrijse
GPLeemrijse marked this pull request as ready for review November 6, 2026 16:51
@GPLeemrijse
GPLeemrijse removed this pull request from stack #259 November 6, 2026 17:20
@GPLeemrijse
GPLeemrijse changed the base branch from fix/local-user-licence-path to fix/local-acquire-licence-path November 6, 2026 17:20
@GPLeemrijse
GPLeemrijse added this pull request to stack #268 November 6, 2026 17:20
…FILE

local_acquire only read COCOTEC_AUTH_TOKEN, so a token given as a file acquired
no licence. COCOTEC_AUTH_TOKEN_FILE now wins; only its path is passed to
cocotec-licensing-server, so the token's contents never enter the build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant