Repository navigation
fix(licensing): acquire the local_acquire licence at fetch time and pass it by path - #264
Open
GPLeemrijse wants to merge 1 commit into
Open
GPLeemrijse wants to merge 1 commit into
GPLeemrijse wants to merge 1 commit into
Conversation
This was referenced Nov 6, 2026
GPLeemrijse
force-pushed
the
fix/local-acquire-licence-path
branch
2 times, most recently
from
November 6, 2026 16:22
926d83f to
7b4d5d6
Compare
GPLeemrijse
marked this pull request as ready for review
November 6, 2026 16:56
GPLeemrijse
force-pushed
the
fix/local-acquire-licence-path
branch
from
November 6, 2026 17:10
7b4d5d6 to
93c4eca
Compare
GPLeemrijse
changed the base branch from
fix/auth-token-file
to
fix/local-user-licence-path
November 6, 2026 17:20
GPLeemrijse
force-pushed
the
fix/local-acquire-licence-path
branch
from
November 6, 2026 17:20
93c4eca to
5f1d0e6
Compare
…ass it by path Under local_acquire the licence is now acquired by one repository per licence protocol version (io_cocotec_licensing_fetch_<n>), with the host's cocotec-licensing-server, and popili gets it by absolute path through the toolchain's new local_acquire_licenses attribute instead of as an action input. A fresh acquisition therefore no longer changes every popili action's key. The toolchains select the licence only under local_acquire, so other modes fetch nothing. Acquisition never fails the fetch, and popili gets the same path whether it succeeded or not, so cached results survive a failure; the reason shows in the action's progress message or the test's output. Bring-your-own toolchains must set local_acquire_licenses, e.g. @rules_coco//coco:local_acquire_licenses_<n>, under local_acquire. fetch_license is removed.
GPLeemrijse
force-pushed
the
fix/local-acquire-licence-path
branch
from
November 6, 2026 17:52
5f1d0e6 to
e852b9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under
local_acquire, the licence is now acquired at fetch time by one repository per licence protocol version (io_cocotec_licensing_fetch_<n>), using the host'scocotec-licensing-serverandCOCOTEC_AUTH_TOKEN(#260 addsCOCOTEC_AUTH_TOKEN_FILE), and passed to popili by absolute path instead of as an action input. A fresh acquisition no longer changes every popili action's key, and the licence is re-acquired once per Bazel server. Toolchains select it only underlocal_acquire, so other modes fetch nothing; a failed acquisition doesn't fail the build, and the reason shows when popili runs.Breaking: bring-your-own toolchains using
local_acquiremust setlocal_acquire_licenses = "@rules_coco//coco:local_acquire_licenses_<n>".fetch_licenseis removed.A real acquisition is exercised only by CI's
local_acquirejobs.