Repository navigation
Conversation
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared capsule publication decoded the complete historical Xet catalog before checking an outgoing pointer. A fixed pointer publication now queries its file binding, candidate shard/xorb identities, and their authenticated dependency closure from the captured view in one aggregate budget. Candidate identities remain necessary when a new file reuses historical artifacts.
Stacked on #577 (
codex/sqlite-wal-safety); review this incremental diff against that branch. No format, dependency, or configuration changes in this PR.Validation:
cargo fmt --all --checkandgit diff --checkpass.double_must_useexpectations incrab-coordination, unchanged relative to this PR's base. These annotations differ from currentorigin/main; this is an inherited stack issue, not a demonstrated failure on main. The broader metadata capsule suite passed all 129 tests. Strict selected-packagecargo clippy --no-depspassed for both changed crates, all targets, and the publication/storage/remote-index feature combination after replacing a test-only cloned slice with a borrowed slice.The regression uses real 8 KiB Xet shard/xorb content for the selected file and synthetic unrelated metadata without payload bodies. It proves selected publication behavior, not complete-repository, S3 latency, or 10 GiB qualification. Those gates remain open.
Evidence map:
crates/crab-http-server/src/receive/publish.rscallsPrepared::upload_capsule.crab-remoteselects outgoing/candidate keys;crab-metadata::PointerCatalogLookup::dependenciesauthenticates the loaded closure; storage retains transport ownership.pointer_catalog_lookup, dependency proof, thenupload_capsule_contentand existing per-ref commit. Leases/GC fences and payload-before-visibility ordering remain required.Is this the best fix? The selected dependency API extends the existing authenticated reader and makes file-only queries delegate to it. It replaces the foreground full scan without a fallback or a second codec. Approximately 53 net production lines add combined candidate selection and closure validation; tests cover the cross-path reuse invariant.
Excluded: the two large-file audit reports and the unrelated local advisor-plan edits. Unified staging, protected receive/hydration, lifecycle qualification and fuller Git blame remain follow-up work; this PR does not claim the overall initiative is complete.