Phase 3: AI improvement pipeline, path anchoring, env-secret gate - #2
Merged
Conversation
The pipeline: propose -> firewall -> implement -> human merge. * improve/sources.py - allowlist of what analysis may READ (published artifacts and the decision log; source code is deliberately not readable evidence). * improve/firewall.py - denylist of what a proposal may CHANGE: seven frozen paths and six change classes, enforced at propose time AND re-run against the actual diff at implement time. Refusals cite the iron rule verbatim. * improve/propose.py - writes docs/proposals/PROP-n only; never edits code. * improve/implement.py - branch, apply, gate, report, push, STOP. No merge verb exists in the module; two tests prove main is never touched. Path anchoring (Defect #1 and its two siblings found by the audit): every module-level default path in glassbox/ now derives from PROJECT_ROOT rather than the CWD. The unattended chain runs in C:\Windows\System32, where a relative Path("reports") raised PermissionError WinError 5 naming a directory that had never existed. verify_dist s .env fallback was the same defect but failed worse: a missing .env is not an error there, so the env-secret search would have silently become a no-op while the gate still reported PASS. Env-secret gate (consequence of Defect #2): in the automated refresh chain, an UNCHECKED env-secret status now aborts at the deploy decision exactly as a redaction does. Interactive and --dry-run keep the note. 668 tests pass; ruff and mypy clean.
These accumulated across the 08-14 and 08-15 refreshes. Committing them clears the provenance warning: the chain records the commit it deployed from, and a dirty tree meant the published bytes cited a commit that did not contain them.
The 18:01Z chain regenerated these after PROP-1 merged; the Story page copy and the manifest commit both moved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits, both already reported in full.
3dc02b3— Phase 3 pipeline + Part A anchoring + env-secret gateimprove/sources.py— allowlist of what analysis may READimprove/firewall.py— denylist of what a proposal may CHANGE (7 frozen paths, 6 change classes), enforced at propose time and re-run against the actual diff at implement timeimprove/propose.py— writesdocs/proposals/PROP-nonly, never edits codeimprove/implement.py— branch, apply, gate, report, push, STOP; no merge verb exists in the moduleglassbox/derives fromPROJECT_ROOT, not the CWD (Defect PROP-1: PROP-1-story-page-undercounts-the-self-caught-incidents-it-sa… #1 and two siblings)8a192ad— outstanding public snapshot captures, clearing the provenance warning.668 tests pass; ruff and mypy clean.
Direct push to
mainis correctly blocked by repository rules, so this goes through review like any other change.