Skip to content

BDSP AutoStory v4: new game to Floaroma as one story table on the shared steps - #128

Draft
dayfine wants to merge 296 commits into
bdsp/actions-v4from
bdsp/autostory-v4
Draft

dayfine wants to merge 296 commits into
bdsp/actions-v4from
bdsp/autostory-v4

Conversation

@dayfine

@dayfine dayfine commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner

Depends on #148 (base bdsp/actions-v4); the diff shows only this PR's change.

BDSP AutoStory rewritten like FRLG's: one table of story steps from 00.00 to 01.11, run by #122's shared engine with its checkpoint dropdowns and stats, written in the shared story steps (ROUTE, LEGS, STEP, TALK, MASH, BATTLE, HEAL) instead of segment functions replaying recorded stick holds.

  • Walks are routes planned on the JSON maps onto the decomp's scene triggers and coord events, with Developer-Butters' button sequences from [WIP] BDSP Autostory PokemonAutomation/Arduino-Source#1717 for the scenes (credited). 01.05–01.10 (folded in from BDSP AutoStory: plan 01.05 to 01.10 on the story maps #175) are map-planned routes and door taps that wait for the location banner; 01.08 starts from the wall west of Rowan's scene.
  • Most named events are now shared steps (folded in from BDSP AutoStory: the story table's named events as shared story steps #173); Events_*.cpp is 725 lines (1,487 before). Still named, because the shared steps don't cover them: the Azure Flute, briefcase, starter choice, catching tutorial and catch (BDSP-only menus and scripts), 00.04c's Mart lady (checks two signs, looks for her up to three times), 00.04d's stairs (Dawn's scene is not on Diamond's trigger), 00.05b's wandering clowns, 01.04's gym loop (walks back from the Center after a loss to keep the experience), and 01.09's Rock Smash (Yes/No box).
  • Maps: the mine's entrance hall (from the decomp), the coal room as a room world, and the mine's warp tiles as doors. TALK waits 8 s for a line (Roark's comes after a camera zoom, r98).
  • Start-save check: a row that saves first names its start map (saves_in). The start save reads the save screen's place name and, if it is not that map, backs out unsaved and stops with FatalProgramException, so a run never saves over a good checkpoint from the wrong place (r76/r77 did).
  • A Pokemon Center is its warm floor (at least 30% of the screen) in a room (indoors()); Jubilife's yellow plaza read as a Center and a won battle was called lost (r79).
  • Fixes from console runs r9–r103 (each named in its commit): door steps watch for the fade themselves, talks turn to the pose's facing first, Center doors in and out, the Ravaged Path exit, settling while Floaroma's cloud shadows move.
  • Small changes to parent PRs' files that the table needs: town plan costs for D-pad legs, Route 201's measured path in RouteRecords and Segment00Lines, and the Center test in the Walk suite.

Testing

  • Suites: StoryTable (lints: a row has saves_in exactly when it saves first, each row starts where the last ends, town routes take the short way), StorySimulation (the whole story in English and Japanese, every route planned), and Walk. Offline on BDSP AutoStory: grid simulation of walks and scenes for unit tests #167's grid simulation (throwaway merges, not part of this PR), every row from 00.04d to 01.11 ends on its table tiles.
  • Console: the start-save check stopped as meant on console B (01.10 started in Floaroma read "floaromatown" and stopped unsaved).
  • Not run on the console yet (from BDSP AutoStory: the story table's named events as shared story steps #173's and BDSP AutoStory: plan 01.05 to 01.10 on the story maps #175's checks): 00.02's Lakefront scene end at (17, 14/15); 00.03's Pokedex scene ending at Rowan; 00.05's start at (48, 62) and Barry's Town Map talk; 01.01's step onto Barry's coord event; 01.02's Gate trainers and Oreburgh welcome scene; 01.03's Center door column (47, not 46), the mine's warps and 19-tap hall, Roark's talk and scene timing; 01.04's 20 taps from where the heal leaves us; 01.05–01.10's routes and door banners; 01.11's 8 taps west and the old couple's talks.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

@dayfine
dayfine changed the base branch from bdsp/nav-v4 to bdsp/walk-v4 November 1, 2026 20:10
@dayfine dayfine changed the title BDSP AutoStory v4: new game to Floaroma on the shared story steps (no #1717) BDSP AutoStory v4: new game to Floaroma as one story table on the shared steps Nov 1, 2026
@dayfine
dayfine changed the base branch from bdsp/walk-v4 to bdsp/actions-v4 November 1, 2026 22:19
@dayfine dayfine added autostory AutoStory programs game:bdsp Brilliant Diamond/Shining Pearl labels Nov 1, 2026
dayfine and others added 4 commits November 1, 2026 17:21
…tostory-v4

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…p row to the stairs

BDSP leaves an Azure Flute on the bedroom floor at (7, 4) when the console has
Legends: Arceus data (found by hand on console B). One tolerant step faces that
tile and presses A, B-ing through any text; without the ball nothing happens.
Then up onto (7, 4) and east over the stairs' mat, one turn fewer than before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The route to (7, 5) ends facing east, its last leg's way (r15), so A hit
nothing and the ball still blocked the step north. A short tap north only
turns.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine and others added 15 commits November 1, 2026 18:04
… console B

r16 by hand: west of the exit path, row 18 is trees and the 201 sign stands at
(13, 18); the dirt goes on along row 17, where the map had the sign. After the
warning: west 1, north 1, then west. The map, the route record and the
segment-00 line follow.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
After the lake, the Lakefront's frame script walks the player 3 south, to
(17, 14) or a tile below (decomp, event timeline 00.02 #5), not onto the
entrance (17, 12). 00.02's end and 00.03's start take either.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…cene

BDSP fades to the house after Barry's line, where Mom gives the Running
Shoes (console r24); Diamond's decomp has no such scene here.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…nd the lines after it

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…lines on arrival

The fade home is a dim, not a black screen, and the scene waited for a
press on a line the detector missed (r26).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Scenes and steps through a door press through text and keep pressing B
until the overworld has been quiet for 5 s: scenes pause, fade dimly and
wait on boxes the detector misses (r23-r26). Stepping onto the house's
door tile goes out once Mom's warning is spent (r27).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
r28 stood a tile beside the door, took the step for the way out and
walked a whole route inside the house. Mom's scene leaves us at (5, 8)
or (6, 8).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine added a commit that referenced this pull request Nov 12, 2026
…tings-lang-free

Picks up #226's code-health fixes after the #128 merge. No conflicts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 12, 2026
…ttle

Picks up #226's code-health fixes after the #128 merge. No conflicts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 12, 2026
Brings #128's seam work down through #167, #226 and #364. No conflicts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 12, 2026
PlannedRoute_Tests.cpp held the scripted-console cases and, since the
#128 merge, its simulated-console cases too, at 975 of 1000 lines; #400's
next case would not fit. SimulatedRouteIO and the cases that use it
(blocked from several tiles, the Jubilife Center walks, the story-route
fault sweep) move unchanged to SimulatedRoute_Tests.cpp, under the same
test names, with their own case table.
Review with: git diff --color-moved HEAD~1

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 12, 2026
…dsp/start-certainty

Brings #128's seam work down the BDSP console stack.
Conflicts:
- bdsp-00.05.plan.json: ours, byte-identical to lab/dev-bdsp (console
  truth). #128's side is 2fe00a0 (legs rewritten as routes: content,
  not a format change), which this branch's 00.05 rewrite supersedes.
- PlannedRoute.cpp: both new RouteWalker functions, mark_tiles_past()
  (#128) and held_up_on_the_way() (this branch), in lab/dev-bdsp's order;
  the file equals lab/dev-bdsp's.
- PlannedRoute_Tests.cpp: the case table keeps this branch's held-up wall
  leg case; the Jubilife held-overshoot case moved with SimulatedRouteIO
  to SimulatedRoute_Tests.cpp in #375.
All plan files equal lab/dev-bdsp's after the merge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 12, 2026
…with #128) into lab/dev-bdsp

Brings #128's seam work (StoryRun shell, start gate, golden plans, fault
sweeps) to console B's branch through #167/#226/#364/#375 and #400.
No plan file changes: every BDSP plan JSON stays as lab/dev-bdsp had it.
Conflicts:
- PlannedRoute_Tests.cpp: theirs. This branch's extra lines were the
  cherry-picked SimulatedRouteIO and its blocked-from-several-tiles case,
  now in SimulatedRoute_Tests.cpp on #375.
- CommonFramework/Main.cpp: keep this branch's cleanup after the
  command-line test mode return (headless runner), with main's PA_SDL
  gamepad tracker stop added to it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 12, 2026
PokemonBDSP::add_tests() already adds them; main's explicit calls in the
runner, brought in with #128, made SerialProgramsTests abort on a
duplicate test name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 12, 2026
#128's golden lists #128's plans, which turned more legs into routes;
lab/dev-bdsp keeps the plan files console B runs, so its golden is
regenerated from the test's GOLDEN| log lines on this branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine and others added 9 commits November 12, 2026 00:12
Follows #402 moving the step tap onto Gait; same 160/640 ms, so presses
are unchanged. Also sorts the MoveMechanics include and drops prefixes the
file's using-declaration covers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
… connected_maps() refuses temporaries (#411 review)

Each row names its plan world's two places, and a pair that is renamed or
dropped fails with their names instead of dereferencing null. Test fields
get defaults and designated names.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine and others added 4 commits November 12, 2026 02:18
# Conflicts:
#	SerialPrograms/Source/ComputerPrograms/ComputerPrograms_UnitTestRunner.cpp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Folded leaf PR #168; tree equals the leaf tip.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autostory AutoStory programs game:bdsp Brilliant Diamond/Shining Pearl

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant