Repository navigation
AutoStory: shared story-run start and finish for BDSP and FRLG - #380
Merged
Merged
Conversation
Start preparation, the runner's reload, and the finish of a run or a verify run, written once for both games. A start at a checkpoint with a save always loads that save first; a failure leaves the game where it failed, with the same log lines in both games. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This was referenced Nov 11, 2026
Pokemon_AutoStoryShell{,_Tests} -> Pokemon_StoryRun{,_Tests}; include
guards, header titles, test suite name and registration follow. No
behaviour change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
marked this pull request as ready for review
November 11, 2026 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #362 (nav/grid-story-steps). Seam 1 of 5 in unifying BDSP and FRLG AutoStory.
BDSP and FRLG each had their own start and finish of a story run, and they drifted: BDSP's start from a save did not reload it (a run started at 00.04b walked from 00.04d's position on console B, 2026-11-11), and BDSP closed the game on failure while FRLG left it. This adds it once in
Pokemon/AutoStory/Pokemon_StoryRun.h; BDSP and FRLG move onto it in their own stacks (follow-up PRs).A game lends only what differs: how it loads its save, how it checks where the save is, and what it rereads after a load. FROM_SAVE always loads the save before the first checkpoint, the same path every retry uses. Nothing in it closes or resets the game on failure: it logs "AutoStory failed: the game stays where it failed." and throws OperationFailedException with the same message in both games. Tested with the new Pokemon::StoryRun suite (start loads the save, wrong place, retry reload, failure leaves the game untouched, finish and verify lines) in the headless runner.
🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss