Repository navigation
BDSP AutoStory: run on the shared story-run start and finish - #381
Merged
Merged
Conversation
The start at a checkpoint with a save now resets from HOME to load it first, as every retry does, so a run never walks from wherever the game was left (console B, 2026-11-11: 00.04b walked from 00.04d's position). Reload, failure and finish lines come from Pokemon/AutoStory's shell. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Supplies the shared story run's preflight (read_story_preflight) and a place check for the loaded save (the save card must name the start row's saves_in). Removes "Just loaded the start's save": a run from a save always loads it and the first row's start save is skipped by the shared rule (only a new game saves before it starts). A failed preflight is a setup error with nothing pressed. save_game() no longer saves blind when the save screen can't be confirmed; it stops with a screenshot (console B, 2026-11-11 13:32: X/R/ZL pressed on HOME). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
marked this pull request as ready for review
November 11, 2026 23:06
dayfine
added a commit
that referenced
this pull request
Nov 11, 2026
…eloads Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #378.
BDSP AutoStory now runs on the shared story-run start and finish from #380. A run that starts at a checkpoint with a save resets from HOME to load it first, the same load every retry uses; before, the start skipped it and a run from 00.04b walked from 00.04d's position (console B, 2026-11-11). Retry, failure ("AutoStory failed: the game stays where it failed."), verify summary and "done through" lines now come from the shared code, as in FRLG, and the finish notification carries that line. BDSP lends only
load_save(reset from HOME), log and status; it has no save-place check yet. The "Just loaded the start's save" option is unchanged. Tested with the Pokemon::StoryRun suite in the headless runner and a compile of the program; not run on the console.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss