Skip to content

Pokemon Navigation: shared fault sweep runner, seeded rows and known-failing list - #513

Merged
dayfine merged 1 commit into
nav/leg-tracefrom
nav/fault-sweep
Nov 15, 2026
Merged

dayfine merged 1 commit into
nav/leg-tracefrom
nav/fault-sweep

Conversation

@dayfine

@dayfine dayfine commented Nov 15, 2026

Copy link
Copy Markdown
Owner

Depends on #464 (base nav/leg-trace); the diff shows only this change.

BDSP's and FRLG's fault sweep tests each carry their own copy of the sweep bookkeeping: the sweep_result() log lines, the clean-first rule, the known-failing wrapper (three copies, counting BDSP's SimFailureCases), and FRLG's seeded wild-battle loops. This adds the shared pieces once, in their final files under Pokemon/Navigation/Simulation/: SimSweep (sweep_result, run_sweep over SweepVariants, sweep_clean_first, variant_failure), SimSeeds (run_seeds with uint32 seeds, 30 by default, mean and worst per measure) and KnownFailing (the pass-while-failing wrapper plus stale() for entries that name no test). The sweep takes the fault class as its log name, so this branch does not need the shared FaultClass; the game PRs pass fault_class_name(). Adoption in BDSP and FRLG follows in one PR per game, keeping test names and outcomes. Tested with new unit tests (Sim sweep, Sim seeds, Known failing suites), run locally in a standalone build of the nav files.

…failing list

SimSweep: sweep_result() (the log lines and message both games' sweeps
print), run_sweep() over SweepVariants, sweep_clean_first() and
variant_failure(). SimSeeds: run_seeds() with uint32 seeds, 30 by
default, logging mean and worst per measure. KnownFailing: the
pass-while-failing wrapper and stale() for entries that name no test.
Unit tests for each; adoption in BDSP and FRLG follows per game.
@dayfine
dayfine marked this pull request as ready for review November 15, 2026 06:53
@dayfine
dayfine merged commit db4b29e into nav/leg-trace Nov 15, 2026
16 of 23 checks passed
@dayfine
dayfine deleted the nav/fault-sweep branch November 15, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant