Repository navigation
Pokemon Navigation: shared fault sweep runner, seeded rows and known-failing list - #513
Merged
Merged
Conversation
…failing list SimSweep: sweep_result() (the log lines and message both games' sweeps print), run_sweep() over SweepVariants, sweep_clean_first() and variant_failure(). SimSeeds: run_seeds() with uint32 seeds, 30 by default, logging mean and worst per measure. KnownFailing: the pass-while-failing wrapper and stale() for entries that name no test. Unit tests for each; adoption in BDSP and FRLG follows per game.
dayfine
marked this pull request as ready for review
November 15, 2026 06:53
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #464 (base
nav/leg-trace); the diff shows only this change.BDSP's and FRLG's fault sweep tests each carry their own copy of the sweep bookkeeping: the
sweep_result()log lines, the clean-first rule, the known-failing wrapper (three copies, counting BDSP's SimFailureCases), and FRLG's seeded wild-battle loops. This adds the shared pieces once, in their final files underPokemon/Navigation/Simulation/:SimSweep(sweep_result,run_sweepoverSweepVariants,sweep_clean_first,variant_failure),SimSeeds(run_seedswith uint32 seeds, 30 by default, mean and worst per measure) andKnownFailing(the pass-while-failing wrapper plusstale()for entries that name no test). The sweep takes the fault class as its log name, so this branch does not need the sharedFaultClass; the game PRs passfault_class_name(). Adoption in BDSP and FRLG follows in one PR per game, keeping test names and outcomes. Tested with new unit tests (Sim sweep, Sim seeds, Known failing suites), run locally in a standalone build of the nav files.