Repository navigation
Conversation
CheckpointId parses "SS.CC" ids like "03.08" (exactly two digits, a dot, two digits), prints them back, orders them, and starts_segment() tells a caller when a run enters a new segment so it can count Segments Started.
FRLG splits boss battles out of a checkpoint without renumbering the ones after it (00.12b, 12.02b). The suffix sorts after the bare id and before the next checkpoint; starts_segment ignores it.
suffix is std::optional<char> instead of a '\0' sentinel, the fields have defaults and are private behind accessors, so parse() is the only way to build an id. Order tests take ids as text. The parse test expects one optional. Sorted the CMake list and the test-runner include; shortened the starts_segment comment.
…ostory/checkpoint-id
CommonTools/ScreenEvents (what the screen is doing, since when) and the shared story vocabulary every AutoStory engine game builds on: the step types, the step executor, story events, the step JSON reader, the story log and the shared failure classes. Cut from plza/fault-sweep with only what PLZA AutoStory builds; the fault sweep's sim-fault mapping comes with the sweep later.
…ry() Keeps the unit test runner's list under the function length limit.
This was referenced Nov 15, 2026
Owner
Author
|
Superseded by the re-split chain #529 to #534 (S1 part, about 500-800 non-test lines each, each with its own tests); its files continue through #535 to #545. The chain's last branch, plza/upstream/s2-11, has the same tree as #525's 00c6ceb. Leaving this open for reference; review the new PRs bottom-up instead. |
dayfine
changed the base branch from
autostory/checkpoint-id
to
autostory/shared-stats
November 15, 2026 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #519
First PR of the rebuilt PLZA upstream chain (plan:
autostory/plza/UPSTREAM_PLAN.md, S1). It addsCommonTools/ScreenEvents(what the screen is doing, since when) and the shared story vocabulary: step types, the step executor, story events, the step and checkpoint JSON readers, the story log and the shared failure classes. The files are cut fromplza/fault-sweep(24133e1) with only what PLZA AutoStory builds; no engine, tile navigation, SV or lab code. Two changes from that tip: the failure classes drop their sim-fault mapping (it returns with the fault sweep after M3), andrecord_story_counts()feeds #519's renamed stats, counting checkpoints started.Tests: the new ScreenEvents, StoryActionArg, StoryLog, StoryEvents, StoryFailureClasses, StoryStepExecutor, StoryStepJson and AuthoredCheckpointJson suites, all synthetic; no CommandLineTests frames needed. Fork Draft CI builds and runs them.