Repository navigation
Respect optional GVEC imports during native-only test collection - #20
Merged
Merged
Conversation
This was referenced Oct 23, 2026
krystophny
marked this pull request as ready for review
October 23, 2026 23:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new VMEC-converter regression imports GVEC during test collection. Native-only CMake CI deliberately has no installed Python package, so collection fails before the existing optional-package fixture can handle it, causing unrelated native executable checks to fail in merge-group run40040160209.
Move the two GVEC imports into the test body. The existing fixture still skips optional package tests and fails when --require-pygvec is requested. The four numerical conversion/readback oracles and their tolerances are unchanged.
Slurm3362376 passed on exact347d21e8de3db070375c3254a4cbe9da2de1cbbf: optional native-only collection gives4skips, while --require-pygvec still produces4real import failures. The installed-package suite passes1314tests (31existing skips,36expected failures), and all17native CMake tests pass with the optional package absent in clean resident generation7cac3b0719e76eaf3dd036d7e72c38343ca0f99a9ccb339025eee0fda1a0d37d. Exact qualified Fo/runtime identities match before/after and the resident owner stopped. The job completed9m26s on4CPU. No workflow, required check or scientific gate is changed.
Chris&AI