Skip to content

Don't load the bfcache handler script on Hyvä themes - #29

Open
GrimLink wants to merge 1 commit into
mage-os:mainfrom
GrimLink:hyva-skip-bfcache-handler
Open

GrimLink wants to merge 1 commit into
mage-os:mainfrom
GrimLink:hyva-skip-bfcache-handler

Conversation

@GrimLink

@GrimLink GrimLink commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Fixes #28

Hyvä Default Theme 1.4+ already resets its components on a bfcache restore (messages, cart drawer, menus, customer section data), so the Hyvä bfcache handler script only duplicated that work and caused a second customer section data request on every restore.

  • default_hyva.xml now removes the theme-optimization.bfcache.main block instead of swapping its template. The response header plugin and URL exclusions are untouched, so bfcache keeps working on Hyvä.
  • Removed the now unused hyva/bfcache/handler.phtml template.
  • Added a note to Update Mini Cart on User Interaction and Auto Close Menu (admin and README) that they have no effect on Hyvä.
  • Added a changelog entry under Unreleased.

Luma behaviour is unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't load the bfcache handler JS on Hyvä

1 participant