Skip to content

fix: stop Claude workflows on review events - #61

Merged
lemarier merged 1 commit into
mainfrom
david/claude-conversation-triggers
Sep 11, 2026
Merged

lemarier merged 1 commit into
mainfrom
david/claude-conversation-triggers

Conversation

@lemarier

@lemarier lemarier commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Change

Copilot reviews on #53 triggered Claude Code workflows that required approval before the job could check for an explicit request. Remove the pull_request_review and pull_request_review_comment triggers and their unused conditions.

Claude remains available through @claude in a new issue or PR conversation comment, or in an issue title/body when opened or assigned. Inline review replies and submitted reviews no longer invoke it. Token permissions, action versions, and execution limits are unchanged.

Validation

  • just check passed: lint, 525 dataset and Worker tests, both application type checks, record validation, site build, and identical dataset builds across 35 files.
  • actionlint .github/workflows/claude.yml and git diff --check passed. Parsed before/after YAML confirms the retained triggers and mention checks, permissions, steps, secrets, and timeouts are preserved.
  • The shared engineering template receives the same trigger change in fix: stop Claude workflows on review events engineering#3. The fix takes effect after merge; no live Claude request was executed for validation.

Copilot AI lite review requested due to automatic review settings September 11, 2026 12:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T12:17:49.589096Z 14520f3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrowly scoped workflow changes have no unresolved blocking issues.

Pull request overview

This PR stops Claude workflows from running on review submissions and inline review comments while preserving supported invocation paths.

Changes:

  • Removed review-related triggers and conditions.
  • Preserved permissions, pinned actions, secrets, and execution limits.
File summaries
File Summary
.github/workflows/claude.yml Restricts Claude invocations to issue and conversation comments.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@lemarier
lemarier merged commit 0b40f8f into main Sep 11, 2026
2 checks passed
@lemarier
lemarier deleted the david/claude-conversation-triggers branch September 11, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants