fix: stop Claude workflows on review events - #3
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
Only minor wording nits remain; no blocking issues were identified.
Pull request overview
Updates the shared Claude workflow to avoid review-triggered runs while preserving explicit @claude requests.
Changes:
- Removes review and inline review-comment triggers and related conditions.
- Simplifies concurrency handling.
- Documents supported request locations.
File summaries
| File | Summary |
|---|---|
templates/workflows/claude.yml |
Restricts workflow activation to explicit issue and conversation requests. |
docs/code-review.md |
Documents valid @claude request locations. |
Review details
Suppressed comments (2)
docs/code-review.md:31
- Once this template is installed, no review-event trigger remains, so this unqualified sentence makes it sound as if the new workflow can still enter approval for Copilot reviews. Qualify it as applying to older installations or the removed configuration so the documentation does not contradict the trigger list and the stated goal of avoiding these prompts.
reviews do not invoke Claude. Copilot review events can require workflow approval
before the job's mention check runs, even when nobody requested Claude.
templates/workflows/claude.yml:4
- This workflow no longer subscribes to review events, so the current-tense comment describes the removed configuration rather than the code below. Rephrase it in past tense or explicitly scope it to older installations; otherwise future maintainers may think the current trigger set still causes approval prompts.
# Copilot review events require approval before the job's mention check runs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Copilot reviews can trigger Claude workflows that require approval before their job checks for an explicit request, as seen in origin89hq/data#53. Remove review and inline review-comment triggers from the shared Claude template, along with their unused conditions and concurrency fallback.
Keep
@clauderequests in new issue or PR conversation comments and issue titles/bodies when opened or assigned. Document where requests belong so future installations avoid the same approval prompts. Token permissions, action versions, and execution limits are unchanged.The installed workflow is updated in origin89hq/data#61. All nine Origin89 repositories were checked; no other default branch contains an affected workflow or template.
Validation
just checkpassed all 31 tests, including Markdown links, JSON fragments, and shared-skill bootstrap behavior.actionlintpassed.git diff --checkpassed.