Skip to content

fix: stop Claude workflows on review events - #3

Merged
lemarier merged 1 commit into
mainfrom
david/claude-conversation-triggers
Sep 11, 2026
Merged

lemarier merged 1 commit into
mainfrom
david/claude-conversation-triggers

Conversation

@lemarier

@lemarier lemarier commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Change

Copilot reviews can trigger Claude workflows that require approval before their job checks for an explicit request, as seen in origin89hq/data#53. Remove review and inline review-comment triggers from the shared Claude template, along with their unused conditions and concurrency fallback.

Keep @claude requests in new issue or PR conversation comments and issue titles/bodies when opened or assigned. Document where requests belong so future installations avoid the same approval prompts. Token permissions, action versions, and execution limits are unchanged.

The installed workflow is updated in origin89hq/data#61. All nine Origin89 repositories were checked; no other default branch contains an affected workflow or template.

Validation

  • just check passed all 31 tests, including Markdown links, JSON fragments, and shared-skill bootstrap behavior.
  • Rendered and installed the template in a disposable consumer; actionlint passed. git diff --check passed.
  • Parsed before/after YAML confirms the retained triggers and mention checks, permissions, steps, secrets, and timeouts are preserved. No live Claude request was executed for validation.

Copilot AI lite review requested due to automatic review settings September 11, 2026 12:16
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T12:17:48.844289Z 93829a2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Only minor wording nits remain; no blocking issues were identified.

Pull request overview

Updates the shared Claude workflow to avoid review-triggered runs while preserving explicit @claude requests.

Changes:

  • Removes review and inline review-comment triggers and related conditions.
  • Simplifies concurrency handling.
  • Documents supported request locations.
File summaries
File Summary
templates/workflows/claude.yml Restricts workflow activation to explicit issue and conversation requests.
docs/code-review.md Documents valid @claude request locations.
Review details

Suppressed comments (2)

docs/code-review.md:31

  • Once this template is installed, no review-event trigger remains, so this unqualified sentence makes it sound as if the new workflow can still enter approval for Copilot reviews. Qualify it as applying to older installations or the removed configuration so the documentation does not contradict the trigger list and the stated goal of avoiding these prompts.
reviews do not invoke Claude. Copilot review events can require workflow approval
before the job's mention check runs, even when nobody requested Claude.

templates/workflows/claude.yml:4

  • This workflow no longer subscribes to review events, so the current-tense comment describes the removed configuration rather than the code below. Rephrase it in past tense or explicitly scope it to older installations; otherwise future maintainers may think the current trigger set still causes approval prompts.
# Copilot review events require approval before the job's mention check runs.
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@lemarier
lemarier merged commit f101e23 into main Sep 11, 2026
2 checks passed
@lemarier
lemarier deleted the david/claude-conversation-triggers branch September 11, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants