fix(deps): bump better-sqlite3 to 13.0.3 for Node 24 - #5359
Merged
openshift-ci[bot] merged 2 commits intoSep 14, 2026
Merged
openshift-ci[bot] merged 2 commits into
openshift-ci[bot] merged 2 commits into
Conversation
Node 24 aborts in better-sqlite3 12.x during Statement teardown (RemoveEnvironmentCleanupHook). 13.x uses N-API. Unblocks rhdh-local dev CI on :next (RHDHBUGS-3725). Signed-off-by: Niall Twomey <ntwomey@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5359 +/- ##
==========================================
- Coverage 63.68% 59.69% -3.99%
==========================================
Files 121 109 -12
Lines 2288 2062 -226
Branches 526 477 -49
==========================================
- Hits 1457 1231 -226
- Misses 829 830 +1
+ Partials 2 1 -1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Author
|
/test e2e-ocp-helm |
Contributor
Author
|
@davidfestal PTAL when you get the chance, should solve the CI checks from failing on the |
Contributor
|
/lgtm |
Contributor
|
tested here: redhat-developer/rhdh-plugin-export-overlays#3564 |
|
jonkoops
approved these changes
Sep 14, 2026
Member
|
/test e2e-ocp-helm |
|
Important The |
3 tasks
jonkoops
added a commit
to jonkoops/rhdh
that referenced
this pull request
Sep 15, 2026
better-sqlite3 13.x needs a native compile during yarn install. The Playwright image only ships skopeo/jq today, so root install fails with "not found: make" after redhat-developer#5359. Ref: RHIDP-15873 Signed-off-by: Jon Koops <jonkoops@gmail.com>
This was referenced Sep 15, 2026
jonkoops
added a commit
to jonkoops/rhdh
that referenced
this pull request
Sep 15, 2026
better-sqlite3 13.x needs a native compile during yarn install. The Playwright image only ships skopeo/jq today, so root install fails with "not found: make" after redhat-developer#5359. Ref: RHIDP-15873 Signed-off-by: Jon Koops <jonkoops@gmail.com>
jonkoops
added a commit
to jonkoops/rhdh
that referenced
this pull request
Sep 15, 2026
better-sqlite3 13.x needs a native compile during yarn install. The Playwright image only ships skopeo/jq today, so root install fails with "not found: make" after redhat-developer#5359. Ref: RHIDP-15873 Signed-off-by: Jon Koops <jonkoops@gmail.com>
jonkoops
added a commit
that referenced
this pull request
Sep 15, 2026
* chore(deps): bump install-dynamic-plugins to 0.5.0 Restrict ref:// resolution to OCI packages in include files, aligning the init container with rhdh-operator#3473. Ref: RHIDP-15873 Signed-off-by: Jon Koops <jonkoops@gmail.com> * fix(ci): install build tools for cluster-free harness better-sqlite3 13.x needs a native compile during yarn install. The Playwright image only ships skopeo/jq today, so root install fails with "not found: make" after #5359. Ref: RHIDP-15873 Signed-off-by: Jon Koops <jonkoops@gmail.com> * Revert "fix(ci): install build tools for cluster-free harness" This reverts commit 111e151. --------- Signed-off-by: Jon Koops <jonkoops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 24 aborts in better-sqlite3 12.x during Statement teardown (
RemoveEnvironmentCleanupHook,env != nullptr). 13.x uses N-API and avoids that crash. This unblocks rhdh-localdevCI, which runsquay.io/rhdh-community/rhdh:nextwith in-memory SQLite.Description
Bump
better-sqlite3from12.11.1to13.0.3inpackages/backend.rhdh-local
devdoes not contain this dependency. It pulls:next, which is built from rhdhmain. After this merges and:nextrebuilds, rhdh-local default compose jobs should stop aborting.Which issue(s) does this PR fix
devCI): ci: test baseline on dev branch rhdh-local#307PR acceptance criteria
yarn starton Node 24 stays up (Listening on :7007, nosqlite native abort):nextrebuild, rhdh-local default / corporate-proxy / dynamic-plugins-root jobs return HTTP 200