Repository navigation
Conversation
relh
marked this pull request as ready for review
September 9, 2026 02:16
relh
commented
Sep 9, 2026
Author
There was a problem hiding this comment.
[Codex, acting on behalf of relh]
Reviewed cedbf5c. One new finding: the new interaction result drops completed clicks for existing press-driven controls. I traced the actual icon, subwindow, and scrubber consumers. The focused icon callback fixture did not complete: its first attempt hit a missing test import, and the corrected attempt could not acquire shared test capacity. I canceled that queued attempt; no runtime success is claimed. This finding is source-verified, not claimed as a passing runtime test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recognize clicks even when a press and release happen between frames. Open dropdown menus above their buttons when there is not enough room below, and move them inward near window edges. Menus taller than the window still need scrolling.
Details
Quick clicks should activate a control once, even when press and release arrive between drawn frames. Use the final held state to recognize a completed click, and let press-driven controls handle it too. The existing interaction tests cover both event orders, ordinary holds, disabled controls, outside releases, and sliders stopping after release.
Dropdown choices now open above their button when they do not fit below, and move inward near window edges. This changes the actual widget placement without adding a second menu system. Lists taller than the entire window still need a scrolling list widget.
Validation: the focused Silky interaction test passes locally. In consuming Polyworld #9, the actual gallery dropdown regression fails before the placement change and passes afterward. A local Chrome run also opened the menu above its button and selected its last option at a 960 by 580 viewport. The consumer pins commit
6efaa6c4a2aedf72e2da718d399d836ebcc613c3and runs its gallery controls in the existing CI workflow.The upstream run is waiting for maintainer approval to run the fork changes. Downstream validation does not replace upstream review.
[Codex, acting on behalf of relh]