Repository navigation
Conversation
There was a problem hiding this comment.
[Codex, acting on behalf of relh]
Reviewed af283b5. No independent actionable finding in safe-area geometry or the gallery layout. This head does pin the Silky change with the completed-click regression: press-driven controls, including the gallery scrubber, ignore clicks whose press and release arrive between frames. Refresh the dependency after that fix and include a completed track click in the gallery proof. I inspected the layout tests and recorded browser/CI evidence; this review did not rerun the browser, and the additional icon fixture could not acquire shared test capacity and was canceled before running.
|
[Codex, acting on behalf of relh] Addressed the dependency issue from the review in The simplify-diff pass retained the existing layout API and widget owner. Regression coverage stays in the existing semantic and browser proofs. The UI workflow passed: upstream widget tests, the gallery's actual controls, native rendering, WebGL build, and live input including a press/release in one browser task followed by mouse movement without dragging. That closes the inherited finding here; the original review summary has no resolvable inline thread. |
|
Simplify pass against #24, #25, #26, #27, #28, #29 at Removed a separate replay-bar overlap calculation from layout validation: the usable game area already excludes that bar. Added boundary checks for a panel that fills the available area, the replay bar itself, and a panel crossing into it. Kept the runnable menus and browser input fixes. Layout tests passed locally. Linux, macOS and Windows CI and the native and live browser gallery proof passed. The gallery proof exercises actual typing, quick clicks, sliders, dropdowns, disabled/repeated rewards, resizing, and scrolling. |
|
The input fixes have now merged upstream:
This PR still pins the older forks. Issue #26 now tracks the remaining adoption work: update pins, remove manual The separate upstream bug trackers #28 and #32 are being closed as fixed upstream. Their downstream integration remains open here and in #26. Preserve the widget work in Silky #67 and the non-Mac wheel-direction fix in Windy #194; neither is included in the newly merged keyboard PRs. Native IME and clipboard behavior remain unverified. |
af23647 to
d80cddb
Compare
|
Closing as deferred. The upstream Windy/Silky input fixes are already pinned on |
Adds a runnable Silky game-menu example with character, settings, and quest panels, plus reusable safe-area layout helpers. Panels account for caller-provided edge insets and replay controls, and oversized panels are clamped to the usable area.
The gallery demonstrates text input, checkboxes, sliders, dropdowns, disabled actions, themes, and scrollable content. It now uses the upstream Silky and Windy revisions already pinned by
main; no dependency forks or PR pins remain. Silky also owns text-input focus automatically, so the old manual rune callback and focus bookkeeping were removed.Deterministic tests cover safe-area geometry and panel fitting. CI builds the atlas and compiles the example. The old coordinate-driven semantic interaction test was removed because it mostly retested upstream controls and was brittle under layout changes.
Feature requests: