Skip to content

fix(chat): isolate the first streamed choice - #101

Merged
PsiACE merged 1 commit into
mainfrom
fix/chat-choice-stream-isolation
Nov 13, 2026
Merged

PsiACE merged 1 commit into
mainfrom
fix/chat-choice-stream-isolation

Conversation

@PsiACE

@PsiACE PsiACE commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Summary

Select choice index zero in Chat streams so other choices do not contribute to the single-response API. Request-level usage remains independent of choice selection.

The existing golden runner replays the byte-identical fixture from openai-python@59738a2, test_parse_pydantic_model_multiple_choices. Assertions cover the selected answer, usage and public streamed/final consistency. The fixture SHA-256 and license are documented with the shared golden inputs.

Stack

Commit ancestry: main (including #102) → #101 → #103 → #104 → #105.

#103 and #104 target their preceding layer for incremental review. #105 targets main and integrates all four layer commits. Merge #105 with a merge commit only after all four current heads have passing native checks and a matching Landing allow. Preserving ancestry lets GitHub mark the lower layers as indirectly merged. Do not squash/rebase the integration merge.

Validation

  • Candidate: 43e52471e995bc5d7d09e71b58f8955a0b6acdf5.
  • uv run pytest -q — 590 passed.
  • uv run prek run --all-files — passed.
  • uv run ty check — passed.
  • Native CI runs on this candidate; Landing is a separate merge gate.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Landing: allow · 43e5247

No blocking findings. The source fix is unchanged from the previously allowed revision; the only delta drops the constructed order-only case, and the retained pinned fixture still fails on the pre-fix parser (index 1 and 2 text merged) while covering usage on an empty-choices chunk.

@PsiACE
PsiACE force-pushed the fix/chat-choice-stream-isolation branch from ef48617 to 43e5247 Compare November 13, 2026 16:19
@PsiACE
PsiACE merged commit 43e5247 into main Nov 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant