Repository navigation
fix(chat): isolate the first streamed choice - #101
Merged
Merged
Conversation
Contributor
|
Landing: allow · 43e5247 No blocking findings. The source fix is unchanged from the previously allowed revision; the only delta drops the constructed order-only case, and the retained pinned fixture still fails on the pre-fix parser (index 1 and 2 text merged) while covering usage on an empty-choices chunk. |
PsiACE
force-pushed
the
fix/chat-choice-stream-isolation
branch
from
November 13, 2026 16:07
588ecd3 to
ef48617
Compare
This was referenced Nov 13, 2026
PsiACE
force-pushed
the
fix/chat-choice-stream-isolation
branch
from
November 13, 2026 16:19
ef48617 to
43e5247
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Select choice index zero in Chat streams so other choices do not contribute to the single-response API. Request-level usage remains independent of choice selection.
The existing golden runner replays the byte-identical fixture from openai-python@59738a2,
test_parse_pydantic_model_multiple_choices. Assertions cover the selected answer, usage and public streamed/final consistency. The fixture SHA-256 and license are documented with the shared golden inputs.Stack
Commit ancestry:
main(including #102) → #101 → #103 → #104 → #105.#103 and #104 target their preceding layer for incremental review. #105 targets
mainand integrates all four layer commits. Merge #105 with a merge commit only after all four current heads have passing native checks and a matching Landingallow. Preserving ancestry lets GitHub mark the lower layers as indirectly merged. Do not squash/rebase the integration merge.Validation
43e52471e995bc5d7d09e71b58f8955a0b6acdf5.uv run pytest -q— 590 passed.uv run prek run --all-files— passed.uv run ty check— passed.