Repository navigation
fix(providers): integrate streaming correctness and golden coverage - #105
Merged
Merged
Conversation
Contributor
|
Landing: allow · d37984b No blocking findings. |
Contributor
There was a problem hiding this comment.
One blocking finding: with an id-less or per-event re-encoded message id, a replacement lifecycle snapshot lands in a second message slot and the stale text is emitted alongside the replacement. Reproduction and repair direction are in the inline thread.
PsiACE
force-pushed
the
fix/responses-lifecycle-replacements
branch
from
November 13, 2026 16:08
77348fe to
a5fa85d
Compare
This was referenced Nov 13, 2026
PsiACE
force-pushed
the
fix/responses-lifecycle-replacements
branch
from
November 13, 2026 16:19
a5fa85d to
d37984b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrate the provider correctness stack:
Stable message IDs and stable
call_idvalues identify snapshot replacements. First-appearance order survives reordered and partial lifecycle lists. There is no identity inference from text contents, output-list positions or provider-specific ID rewriting.Evidence and scope
The lifecycle input serializes openai-python@59738a2,
test_final_output_keeps_completed_lifecycle_replacements, withterminal="null",duplicate=Falseandtool_id="null". It preserves the upstream event order and sequence numbers. The shared golden README records the exact SHA-256 and license.This SDK synthetic robustness case covers sparse item indices, reordered/partial lifecycle snapshots, replacement text/tool arguments and null terminal output. It is not a production recording and does not establish support for changing/absent message IDs or combinations involving Copilot. Unsupported hypothetical combinations are not acceptance criteria.
Golden assertions use public responses and the existing streamed/final consistency helper, not parser internals.
Stack
Commit ancestry:
main(including #102) → #101 → #103 → #104 → #105.#103 and #104 target their preceding layer for incremental review. #105 targets
mainand integrates all four layer commits. Merge #105 with a merge commit only after all four current heads have passing native checks and a matching Landingallow. Preserving ancestry lets GitHub mark the lower layers as indirectly merged. Do not squash/rebase the integration merge.Validation
d37984b9040fc8f6da8ae1845c59fd10c395ec2f.uv run pytest -q— 598 passed.uv run prek run --all-files— passed.uv run ty check— passed.Updated result, onelookupcall with{"answer":5}).mainand all three preceding layer commits are ancestors of this candidate.