Skip to content

test: extend the shared provider golden suite - #103

Closed
PsiACE wants to merge 1 commit into
fix/chat-choice-stream-isolationfrom
tests/recorded-provider-goldens
Closed

PsiACE wants to merge 1 commit into
fix/chat-choice-stream-isolationfrom
tests/recorded-provider-goldens

Conversation

@PsiACE

@PsiACE PsiACE commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Summary

Extend the existing Goose/Fantasy golden suite with six provider recordings for Z.ai, Grok, OpenRouter and Azure. Numbered JSON/SSE inputs, loading, streaming consistency and tool round trips share one runner. PROVIDER-SAMPLES.md pins the Fantasy source commit, cassette paths, transformations and response hashes. Republic request conventions are distinguished from the recording evidence. No production code or dependencies change.

Stack

Commit ancestry: main (including #102) → #101 → #103 → #104 → #105.

#103 and #104 target their preceding layer for incremental review. #105 targets main and integrates all four layer commits. Merge #105 with a merge commit only after all four current heads have passing native checks and a matching Landing allow. Preserving ancestry lets GitHub mark the lower layers as indirectly merged. Do not squash/rebase the integration merge.

Validation

  • Candidate: c57626f033e2caf6e2154d28092d5764eaa8dd69.
  • uv run pytest -q — 596 passed.
  • uv run prek run --all-files — passed.
  • uv run ty check — passed.
  • Native CI runs on this candidate; Landing is a separate merge gate.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two documentation-accuracy issues in the new bucket docs; the test move, the renames and the recorded provenance otherwise check out.

Comment thread tests/test_provider_golden/README.md Resolved
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Landing: allow · c57626f

No blocking findings. The six new cases and PROVIDER-SAMPLES.md check out at this revision: all ten bodies are byte-identical to the pinned Fantasy cassettes at b0fadc9, the six upstream file hashes and the Fantasy license hash in the doc match, the referenced paths and provider mappings (max_tokens for Z.ai, api-key for Azure) agree with docs/providers/, and the earlier stale-path and provenance findings no longer apply to the squashed candidate.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One stale path in the provenance doc; the consolidation otherwise checks out (44 nodes pass, and the recorded provider bodies keep their pinned SHA-256).

Non-blocking: the PR title and body still describe the recording/contract split that 4bfda4f reverted, so the merge commit message will record a separation the tree does not have.

@PsiACE PsiACE changed the title test: separate recorded goldens from synthetic contracts test: extend the shared provider golden suite Nov 13, 2026
@PsiACE
PsiACE changed the base branch from main to fix/chat-choice-stream-isolation November 13, 2026 16:07
@PsiACE
PsiACE force-pushed the tests/recorded-provider-goldens branch from e1d20b0 to b35523c Compare November 13, 2026 16:07
@PsiACE
PsiACE force-pushed the fix/chat-choice-stream-isolation branch from ef48617 to 43e5247 Compare November 13, 2026 16:19
@PsiACE
PsiACE force-pushed the tests/recorded-provider-goldens branch from b35523c to c57626f Compare November 13, 2026 16:19
@PsiACE

PsiACE commented Nov 13, 2026

Copy link
Copy Markdown
Member Author

Incorporated into main through the top-of-stack merge of #105, merge commit 02ab86123f3def1795ed0479bf5ab71a74f46c00. Verified that this candidate, c57626f033e2caf6e2154d28092d5764eaa8dd69, is an ancestor of main; all four stack candidates had current-head Landing allow decisions and passing native checks before the merge. GitHub left this PR open because its base is the lower stack branch, and refuses retargeting to main because there are no new commits. Closing as already incorporated, without an additional merge or any branch rewrite.

@PsiACE PsiACE closed this Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant