Repository navigation
Conversation
There was a problem hiding this comment.
One gap keeps the null-item crash reachable for github-copilot responses streams (inline). Also minor: the description's "Reject other non-object items" no longer has an implementation or test — a non-object item reaches payload["item"].get(...) and raises AttributeError, not a controlled error. Either restore that guard or amend the claim.
c9b0807 to
503ad9a
Compare
b35523c to
c57626f
Compare
503ad9a to
809ecce
Compare
|
Landing: allow · 809ecce
|
There was a problem hiding this comment.
Landing: allow · 809ecce
The Copilot null-item gap was withdrawn on this exact SHA after base/candidate comparison (reassessment) and its thread is resolved, so no blocking finding remains against the current diff.
Scope is unchanged: src/republic/formats/responses.py plus the golden case, its README note and one golden test. At this head the case passes (597 tests), the recorded 0.sse SHA-256 matches the README, src/republic/providers/github.py is identical to base, and Main CI run 43461634187 succeeded. The evidence boundary is unchanged — the null-item case stays pinned to the upstream OpenAI SDK example with no Copilot-specific claim.
|
Incorporated into |
Summary
Ignore Responses output-item added/done events whose
itemis absent or null, preserving subsequent valid text and tool calls.The public OpenAI streaming test replays the exact event construction from openai-python@59738a2,
test_stream_preserves_output_after_empty_item, withmissing=False,index=0andnull_completion=True. The numbered SSE input includes upstream sequence numbers; its SHA-256 and license are documented in the shared golden directory.This is a synthetic SDK robustness case, not a production recording. This layer makes no non-streaming or Copilot-specific changes.
Stack
Commit ancestry:
main(including #102) → #101 → #103 → #104 → #105.#103 and #104 target their preceding layer for incremental review. #105 targets
mainand integrates all four layer commits. Merge #105 with a merge commit only after all four current heads have passing native checks and a matching Landingallow. Preserving ancestry lets GitHub mark the lower layers as indirectly merged. Do not squash/rebase the integration merge.Validation
809ecce383dba8ea484c41f8b2d25c96a73afab8.uv run pytest -q— 597 passed.uv run prek run --all-files— passed.uv run ty check— passed.