Skip to content

Pokemon Navigation: leg trace and replay of console failures - #464

Draft
dayfine wants to merge 4 commits into
nav/grid-story-stepsfrom
nav/leg-trace
Draft

dayfine wants to merge 4 commits into
nav/grid-story-stepsfrom
nav/leg-trace

Conversation

@dayfine

@dayfine dayfine commented Nov 13, 2026

Copy link
Copy Markdown
Owner

Base: nav/grid-story-steps at ea17f73, the newest commit both the BDSP and the FRLG chains already contain; the diff shows only this change.

The leg trace and the console-failure replay were shared Navigation code living inside game PRs: LegTracer came with the BDSP lab core and with the FRLG walker commit 9499c3f (#451), and LegReplay with #447 and again with 9499c3f. This PR holds the one shared copy, unchanged: Pokemon_LegTrace (the [Leg] record writer and reader), Pokemon_LegReplay (the fault-file reader), the LegTrace unit tests, and the Python grader devtools/maps/leg_trace.py plus the fault-file tool leg_replay.py. The game PRs merge it in, so their diffs keep only the walkers, sims and fault data. Checked by compiling the four Navigation objects and running the leg_trace Python tests (the golden-file test skips without the BDSP golden).

🤖 Generated with Claude Code

https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

The shared [Leg] record writer and reader (LegTracer), the fault-file reader
for replaying a console failure on a sim (LegReplay), their unit tests, and
the Python grader and fault-file tools under devtools/maps. Taken unchanged
from the FRLG walker commit and nav/leg-replay (#447) so both games build on
one copy.

(cherry picked from the shared parts of commit 9499c3f
and devtools/maps/leg_replay.py from 98c0b61)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 13, 2026
…eg trace and replay

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 13, 2026
…ared leg trace and replay (#464)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 13, 2026
…leg trace and replay

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 13, 2026
…d leg trace and replay (#464)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 13, 2026
…red leg trace and replay (#464)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

# Conflicts:
#	devtools/maps/tests/test_leg_trace.py
dayfine added a commit that referenced this pull request Nov 13, 2026
…leg trace and replay (#464)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 13, 2026
… trace and replay (#464)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 13, 2026
… trace and replay (#464)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 13, 2026
…eg trace and replay (#464)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine and others added 2 commits November 14, 2026 07:00
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…failing list

SimSweep: sweep_result() (the log lines and message both games' sweeps
print), run_sweep() over SweepVariants, sweep_clean_first() and
variant_failure(). SimSeeds: run_seeds() with uint32 seeds, 30 by
default, logging mean and worst per measure. KnownFailing: the
pass-while-failing wrapper and stale() for entries that name no test.
Unit tests for each; adoption in BDSP and FRLG follows per game.
Pokemon Navigation: shared fault sweep runner, seeded rows and known-failing list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant