Repository navigation
Conversation
dayfine
force-pushed
the
bbq/save-milestone-tracker
branch
from
October 21, 2026 04:10
2344b3f to
64fe041
Compare
dayfine
force-pushed
the
bbq/save-milestone-tracker
branch
3 times, most recently
from
October 21, 2026 04:43
0c2de62 to
9fad4d8
Compare
dayfine
force-pushed
the
bbq/save-milestone-tracker
branch
from
October 21, 2026 04:55
9fad4d8 to
d73d9d7
Compare
BBQSoloFarmer::program() runs its quest rounds inline against the console, so the round logic (which quests count, when to stop, when to save) can only be exercised by running the farmer on a Switch. Move the round loop into run_bbq_rounds(), which takes the game actions it depends on as a BBQGameActions interface: read the quests, process them, do a quest, report a completed quest, and end the round (saving if due). BBQSoloFarmer implements these with the calls they replace, in the same order; the date fix, save/reset, stats and notification move together into end_round(). Startup, flying to the plaza and end-of-program handling stay in program(). The commented-out single-quest debug block declares its own egg counter now that the loop locals have moved. process_quest_list() only reads its quest list and egg count, so take them as const& and by value. Add PokemonSV::BBQFarmerRounds, a table of scenarios run against a simulated singleplayer quest panel: 3 blue quests, completed quests are replaced, impossible quests are skipped, and a panel with nothing doable is rerolled. Each scenario checks the number of completed quests and the exact action sequence: finishing the round that reaches the goal, a quest already gone, a failed quest, a panel with nothing doable, saving at exact multiples, and stopping when out of eggs. No behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/save-milestone-tracker
branch
from
October 21, 2026 05:04
d73d9d7 to
ea359ba
Compare
dayfine
marked this pull request as ready for review
October 21, 2026 05:14
Contributor
Author
|
@jw098 PTAL - also a refactor that sets up some testing and expectations, to make later changes easier |
dayfine
added a commit
to dayfine/Arduino-Source
that referenced
this pull request
Oct 21, 2026
process_quest_list() takes the panel by const reference since PokemonAutomation#1632, so the rerolls work on a copy.
This was referenced Oct 22, 2026
Open
Windows Clang (clang-cl /W4 /WX) errors on designated initializers that leave out a field with no default member initializer (-Wmissing-designated-field-initializers); tests built on these scenarios omit these fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
marked this pull request as draft
October 23, 2026 17:48
Contributor
Author
|
Closing for now to keep at most two PRs open, per CONTRIBUTIONS.md. I'll resend this later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the BBQ Farmer's round loop out of
program()intorun_bbq_rounds(), which talks to the game through a smallBBQGameActionsinterface. No behavior change. This lets the round logic (what counts, when to stop, when to save) be tested without a Switch:PokemonSV::BBQFarmerRoundsruns scenarios against a simulated quest panel. The loop body is unchanged apart from swapping console calls forgame.calls.🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E